Jp 918 Correct bar shadow parity bug for yslit #5095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5095 +/- ##
=======================================
Coverage 53.04% 53.04%
=======================================
Files 401 401
Lines 35607 35607
Branches 5519 5519
=======================================
Hits 18886 18886
Misses 15582 15582
Partials 1139 1139
Continue to review full report at Codecov.
|
hbushouse
approved these changes
Jun 23, 2020
CHANGES.rst
Outdated
| @@ -16,6 +16,10 @@ associations | |||
|
|
|||
| - Update diagrams to change sloper to detector1. [#4986] | |||
|
|
|||
| barshadow | |||
There was a problem hiding this comment.
Not sure it matters, but you might need to remove the extra whitespaces in front of this section title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a correction for the fact that the yslit values in a 2D science spectrum decrease from bottom to top but in the reference file they increase from bottom to top.
Fixes #3897 / JP-918