10000 JP-1554: Add TIMEUNIT keyword by hbushouse · Pull Request #5109 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-1554: Add TIMEUNIT keyword #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Conversation

hbushouse
Copy link
Collaborator

Update all existing schemas that contain the TIMESYS keyword to also include TIMEUNIT, with specs as outlined in JP-1554 and requested in JWSTKD-97.

Should cause lots of regression test failures, due to extra keyword showing up in all outputs. Warming up okify_regtests now ...

Fixes #5101 / JP-1554

@hbushouse hbushouse added datamodels keywords Anything related to FITS header keywords labels Jun 29, 2020
@hbushouse hbushouse added this to the Build 7.6 milestone Jun 29, 2020
Copy link
Collaborator
@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
codecov bot commented Jun 29, 2020

Codecov Report

Merging #5109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5109   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files         401      401           
  Lines       35608    35608           
  Branches     5520     5520           
=======================================
  Hits        18882    18882           
  Misses      15586    15586           
  Partials     1140     1140           
Flag Coverage Δ
#unit 53.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603d115...640dd58. Read the comment docs.

< B1D2 /td>

@hbushouse hbushouse merged commit 079b632 into spacetelescope:master Jun 29, 2020
@hbushouse hbushouse deleted the jp1554 branch June 29, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodels keywords Anything related to FITS header keywords
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TIMEUNIT keyword to core schema
2 participants
0