8000 Update underlying MultiExposureModel from the SourceModelContainer models by stscieisenhamer · Pull Request #5154 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update underlying MultiExposureModel from the SourceModelContainer models #5154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2020
Merged

Update underlying MultiExposureModel from the SourceModelContainer models #5154

merged 2 commits into from
Jul 20, 2020

Conversation

stscieisenhamer
Copy link
Collaborator

Regression error where changes to the wrapped models in SourceModelContainer are not propagated back to the underlying MultiExposureModel.

@stscieisenhamer stscieisenhamer self-assigned this Jul 20, 2020
@codecov
Copy link
codecov bot commented Jul 20, 2020

Codecov Report

Merging #5154 into master will increase coverage by 0.04%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5154      +/-   ##
==========================================
+ Coverage   52.49%   52.53%   +0.04%     
==========================================
  Files         403      406       +3     
  Lines       36227    36252      +25     
  Branches     5616     5616              
==========================================
+ Hits        19016    19046      +30     
+ Misses      16030    16029       -1     
+ Partials     1181     1177       -4
Flag Coverage Δ
#unit 52.53% <28.57%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jwst/outlier_detection/outlier_detection.py 40.27% <ø> (ø)
jwst/datamodels/source_container.py 57.14% <28.57%> (-3.73%) ⬇️
jwst/pipeline/calwebb_spec2.py 33.75% <0.00%> (-0.46%) ⬇️
jwst/stpipe/step.py 81.67% <0.00%> (-0.21%) ⬇️
jwst/lib/suffix.py 95.18% <0.00%> (ø)
jwst/extract_2d/extract_2d.py 50.00% <0.00%> (ø)
jwst/extract_2d/extract_2d_step.py 100.00% <0.00%> (ø)
jwst/wavecorr/wavecorr.py 13.88% <0.00%> (ø)
jwst/wavecorr/wavecorr_step.py 23.52% <0.00%> (ø)
jwst/wavecorr/__init__.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c6906...78f4f61. Read the comment docs.

@hbushouse hbushouse added this to the Build 7.6 milestone Jul 20, 2020
hbushouse
hbushouse approved these changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a change log entry.

@stscieisenhamer stscieisenhamer merged commit 5aa1777 into spacetelescope:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees

@stscieisenhamer stscieisenhamer

Labels
bug datamodels
Projects
None yet
Milestone
Build 7.6
Development

Successfully merging this pull request may close these issues.
2 participants
@stscieisenhamer @hbushouse
0