JP-1636: Fix slit wcs issue in extract_1d apcorr #5260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5260 +/- ##
==========================================
- Coverage 52.41% 52.41% -0.01%
==========================================
Files 406 406
Lines 36411 36415 +4
Branches 5636 5638 +2
==========================================
+ Hits 19086 19087 +1
- Misses 16146 16149 +3
Partials 1179 1179
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stscieisenhamer
approved these changes
Aug 19, 2020
nden
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract_1dwas failing when trying to process NIRSpec FS or MOS data in aMultiSlitModelwhen trying to compute the pixel scale (converting arcsec from ref file to pixels), because it was trying to use the WCS from the first slit instance in the model for all slits. This was giving null/NaN results for all slits other than the first. So this updates the routine to use the WCS object for the particular slit being processed. Required adding the slit name to theApCorrbase class, so that it's available for use.Fixes #5229 / JP-1636