JP-509 Implement NIRSpec MOS master background subtraction calwebb_spec2 #5302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe#5221) * A few minor updates to create_background_from_multislit * fix a flake8 issue
* JP-1631: implement master bkg mapping to MOS slits * Fix function reference
Changes: * Start spec2 refactor. Move bkg_subtraction decision tree * Move step checking for imprint and msa_flagging * Move step decisions for straylight, fring, pathloss, and barshadow * Move all the step decisions to _step_verification * Bug fixes from refactor * Break of processing into individual methods specific to data types * Fix PEP8 and add changelog * Updates from reviewer comments and typo fixes * Move common step settings up front. * Put initial input in a context manager.
Changes: * Implement inversion for nirspec msa * Add inversion for nirspec bright object * Implement inversion for nirspec ifu * Completed inversion for all other modes * Record user-supplied flat as R_FLAT * Remove use of datamodels.open in a test * Fix sphinx build issue * Use the already opened datamodel to retrieve filename from * Remove unused import * More docstring fixes but not sure if these are the problems
Changes: * Update to match master and restrict to one test again * Update to versions in master * Add back setting of artifactory env * Remove single test
hbushouse
reviewed
Sep 2, 2020
jdavies-st
reviewed
Sep 2, 2020
hbushouse
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-509
Resolves #3073