8000 JP-1681: Fix empty int_times table in rateints products by hbushouse · Pull Request #5321 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-1681: Fix empty int_times table in rateints products #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2020
Merged

JP-1681: Fix empty int_times table in rateints products #5321

merged 3 commits into from
Sep 11, 2020

Conversation

hbushouse
Copy link
Collaborator

Fix ramp_fit to populate the int_times attribute in the rateints products. I think it got removed during the rework to add multi-processing.

Fixes #5320 / JP-1681

@hbushouse hbushouse added this to the Build 7.6 milestone Sep 10, 2020
jdavies-st
jdavies-st reviewed Sep 10, 2020
View reviewed changes
Copy link
Collaborator
@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you add a small addition to the unit tests that checks this new code, or maybe reproduces the old error and shows this fixes it?

@codecov
Copy link
codecov bot commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #5321 into master will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5321   +/-   ##
=======================================
  Coverage   52.75%   52.76%           
=======================================
  Files         406      406           
  Lines       36787    36788    +1     
  Branches     5709     5709           
=======================================
+ Hits        19407    19411    +4     
+ Misses      16140    16139    -1     
+ Partials     1240     1238    -2
Flag Coverage Δ
#unit 52.76% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jwst/ramp_fitting/ramp_fit.py 75.34% <50.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb39f7...c97e6ad. Read the comment docs.

@hbushouse
Copy link
Collaborator Author

Looks good. Could you add a small addition to the unit tests that checks this new code, or maybe reproduces the old error and shows this fixes it?

I could create such a test, but it would take a little work to build (on the fly) an appropriate input image that contains a populated INT_TIMES table, rather than having it use an existing FITS file. So, I'll think about it ;-)

@jdavies-st
Copy link
Collaborator

The existing tests have fixtures that produce on-the-fly data with int times populated.

jwst/jwst/ramp_fitting/tests/test_ramp_fit.py

Line 671 in adb39f7

model1 = RampModel(data=data, err=err, pixeldq=pixdq, groupdq=gdq, times=times)

I think you just need to write a very short test that checks that its there at the end, or add it to one of the existing tests.

https://github.com/spacetelescope/jwst/blob/master/jwst/ramp_fitting/tests/test_ramp_fit.py

@hbushouse hbushouse merged commit 4055a1b into spacetelescope:master Sep 11, 2020
@hbushouse hbushouse deleted the jp-1681 branch September 11, 2020 11:36
@stscijgbot-jp stscijgbot-jp mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavies-st jdavies-st jdavies-st left review comments

@dmggh dmggh dmggh approved these changes

Assignees
No one assigned
Labels
ramp_fitting
Projects
None yet
Milestone
Build 7.6
Development

Successfully merging this pull request may close these issues.

rateints product has zero rows in INT_TIMES table
3 participants
@hbushouse @jdavies-st @dmggh
0