Allow skymatch/skysub for one image #5423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5423 +/- ##
==========================================
- Coverage 52.37% 52.37% -0.01%
==========================================
Files 414 414
Lines 37707 37710 +3
Branches 5838 5839 +1
==========================================
Hits 19750 19750
- Misses 16697 16700 +3
Partials 1260 1260
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hbushouse
reviewed
Oct 22, 2020
8000
CHANGES.rst
Outdated
| @@ -414,6 +414,9 @@ pipeline | |||
|
|
|||
| - Enable NIRSpec lamp processing in calspec2 pipeline. [#5267] | |||
|
|
|||
| - Update ``Image3Pipeline`` to allow sky subtraction when input contains | |||
There was a problem hiding this comment.
It looks like this got added down in the section for one of the previous builds. It should be in the section at the top, for release 0.17.2. Just add a section for "pipeline" between "outlier_detection" and "ramp_fitting" and move this entry up there.
jdavies-st
approved these changes
Oct 23, 2020
hbushouse
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
skymatchstep to run even for a single input image. This essentially will become simple sky background subtraction without matching. Also see helpdesk issue INC0159018.