JP-1776: Update photom to compute uniform and ps corrections #5463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jp1776_nrsphot
…jp1776_nrsphot
…jp1776_nrsphot
stscieisenhamer
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the NIRSpec fixed-slit/MSA branch of the
photom_iofunction to compute both uniform and point source conversion factors for the NIRSpec fixed-slit primary slit when it contains a point source. Both versions of the correction are stored in the output slit instance for use later by themaster_backgroundstep, for applying corrections.Note that the uniform source correction uses the WCS object to compute an uncorrected wavelength grid for the slit, while the point source correction uses the existing 2D wavelength array, because it contains corrected wavelengths. Once the
wavecorrstep gets updated to include the wavelength correction as another transform in the WCS object, the uncorrected wavelengths will need to be computed from the WCS by excluding that new transform.Fixes #5458 / JP-1776