8000 Remove deprecated method get_children from XML elements by stscirij · Pull Request #5536 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated method get_children from XML elements #5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2020
Merged

Remove deprecated method get_children from XML elements #5536

merged 2 commits into from
Dec 17, 2020

Conversation

stscirij
Copy link
Contributor

Also PATTSIZE needs to be a string

@codecov
Copy link
codecov bot commented Dec 15, 2020 •
edited
Loading

Codecov Report

Merging #5536 (79cdc1d) into master (5a87571) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5536      +/-   ##
==========================================
- Coverage   71.24%   71.21%   -0.04%     
==========================================
  Files         410      410              
  Lines       36393    36534     +141     
  Branches     5658     5689      +31     
==========================================
+ Hits        25928    26017      +89     
- Misses       8815     8868      +53     
+ Partials     1650     1649       -1
Flag Coverage Δ *Carryforward flag
nightly 71.17% <0.00%> (-0.07%) ⬇️ Carriedforward from f5717af
unit 51.78% <0.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/fits_generator/proposalparser.py 6.25% <0.00%> (ø)
jwst/tso_photometry/tso_photometry_step.py 18.75% <0.00%> (-42.55%) ⬇️
jwst/resample/resample.py 92.46% <0.00%> (-2.33%) ⬇️
jwst/assign_wcs/assign_wcs_step.py 78.57% <0.00%> (-1.99%) ⬇️
jwst/pipeline/calwebb_tso3.py 81.70% <0.00%> (-1.22%) ⬇️
jwst/regtest/regtestdata.py 79.01% <0.00%> (+0.89%) ⬆️
jwst/tso_photometry/tso_photometry.py 92.12% <0.00%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a87571...79cdc1d. Read the comment docs.

hbushouse
hbushouse approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requisite reminder for a change log entry ...

@hbushouse hbushouse added this to the Build 7.7 milestone Dec 15, 2020
@hbushouse hbushouse merged commit 34232b5 into spacetelescope:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@jemorrison jemorrison Awaiting requested review from jemorrison

Assignees
No one assigned
Labels
fits_generator
Projects
None yet
Milestone
Build 7.7
Development

Successfully merging this pull request may close these issues.
2 participants
@stscirij @hbushouse
0