8000 Fix a crash in skymatch when using mode on 1 pixel by mcara · Pull Request #5567 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix a crash in skymatch when using mode on 1 pixel #5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

mcara
Copy link
Member
@mcara mcara commented Dec 24, 2020

Fixes #5565 (SKYMATCH GLOBAL is NAN)

@mcara mcara self-assigned this Dec 24, 2020
@codecov
Copy link
codecov bot commented Dec 24, 2020

Codecov Report

Merging #5567 (464c18d) into master (263e261) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5567      +/-   ##
==========================================
- Coverage   71.23%   71.22%   -0.01%     
==========================================
  Files         410      410              
  Lines       36467    36470       +3     
  Branches     5720     5721       +1     
==========================================
  Hits        25977    25977              
- Misses       8839     8842       +3     
  Partials     1651     1651              
Flag Coverage Δ *Carryforward flag
nightly 71.22% <ø> (ø) Carriedforward from 263e261
unit 51.84% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/skymatch/skyimage.py 56.37% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 263e261...464c18d. Read the comment docs.

Copy link
Collaborator
@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concise Fix! Thanks Mihai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FITS cannot write NAN value possibly because SKYMATCH GLOBAL is NAN
2 participants
0