8000 xfail NIRCam grism tests until ref files are fixed by hbushouse · Pull Request #6871 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

xfail NIRCam grism tests until ref files are fixed #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2022
Merged

xfail NIRCam grism tests until ref files are fixed #6871

merged 2 commits into from
Jun 7, 2022

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented Jun 7, 2022 •
edited
Loading

Description

This PR temporarily xfails a couple of unit tests in assign_wcs, which are failing (different results) due to new NIRCam specwcs ref files installed in CRDS recently. They will soon be replaced by yet newer versions. So xfail the tests for now, so that CI tests can pass again.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@hbushouse hbushouse added the tests label Jun 7, 2022
@hbushouse hbushouse requested review from nden and stscieisenhamer June 7, 2022 14:03
stscieisenhamer
stscieisenhamer approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator
@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides suggestion, LGTM

@codecov
Copy link
codecov bot commented Jun 7, 2022 •
edited
Loading

Codecov Report

Merging #6871 (65c4321) into master (2f95584) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6871      +/-   ##
==========================================
+ Coverage   79.41%   79.42%   +0.01%     
==========================================
  Files         418      418              
  Lines       37098    37098              
==========================================
+ Hits        29461    29466       +5     
+ Misses       7637     7632       -5
Flag Coverage Δ *Carryforward flag
nightly 79.41% <ø> (ø) Carriedforward from e5f7fa6
unit 53.47% <ø> (?)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/regtest/conftest.py 88.04% <0.00%> (+0.54%) ⬆️
jwst/lib/engdb_direct.py 100.00% <0.00%> (+0.96%) ⬆️
jwst/stpipe/utilities.py 97.82% <0.00%> (+2.17%) ⬆️
jwst/transforms/integration.py 82.35% <0.00%> (+5.88%) ⬆️
jwst/lib/engdb_tools.py 100.00% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f95584...65c4321. Read the comment docs.

@zacharyburnett zacharyburnett mentioned this pull request Jun 7, 2022
Closed
5 tasks
@hbushouse hbushouse merged commit 77640d4 into spacetelescope:master Jun 7, 2022
@hbushouse hbushouse deleted the xfail_tests branch June 7, 2022 17:06
zacharyburnett added a commit that referenced this pull request Jun 20, 2022
@zacharyburnett
freeze changelog for 1.5.3 release (#6881, #6879, #6876, #6864, #6871…
8956295 
…, and #6865 are not included in changelog)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

@nden nden Awaiting requested review from nden

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbushouse @stscieisenhamer
0