JP-2623: Multiprocessing failure in ramp fitting. #6880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to changes to one group ramp suppression.
hbushouse
reviewed
Jun 13, 2022
hbushouse
approved these changes
Jun 14, 2022
|
Looks good now. Obviously need to wait to merge until the supporting changes in stcal have been merged and released. |
dmggh
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
The latest updates look good to me; a couple minor comments on the existing function docs in ramp_fit_step.py :
-
Lines 78, 113 and 148 of ramp_fit_step.py should be "Returns"
-
int_times in 'def create_integration_model( ... ) ' should be included in the epydocs
|
I have used this branch and the accompanying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Resolves JP-2623
Description
The primary cause of the multiprocessing failure was the
int_timesobject, which is anastropy.ioobject that cannot be properly pickled. Since it is not used in ramp fitting, it is no longer passed toSTCALramp fitting and is handled entirely in the ramp fitting step code.Checklist