8000 copy changelog workflow from `asdf` by zacharyburnett · Pull Request #6890 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

copy changelog workflow from asdf #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

zacharyburnett
Copy link
Collaborator
@zacharyburnett zacharyburnett commented Jun 16, 2022

Description

this workflow ensures that a pull request has a corresponding entry in the changelog, unless labeled no-changelog-entry-needed

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@zacharyburnett zacharyburnett self-assigned this Jun 16, 2022
@codecov
Copy link
codecov bot commented Jun 16, 2022

Codecov Report

Merging #6890 (52edc58) into master (b422373) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6890   +/-   ##
=======================================
  Coverage   79.51%   79.51%           
=======================================
  Files         418      418           
  Lines       37328    37328           
=======================================
  Hits        29680    29680           
  Misses       7648     7648           
Flag Coverage Δ *Carryforward flag
nightly 79.49% <ø> (ø) Carriedforward from b422373
unit 53.30% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b422373...52edc58. Read the comment docs.

@nden nden requested a review from hbushouse June 21, 2022 16:45
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (?)

@hbushouse hbushouse merged commit deda044 into spacetelescope:master Jun 21, 2022
@zacharyburnett zacharyburnett deleted the ensure_changelog branch June 21, 2022 20:38
@pllim
Copy link
Collaborator
pllim commented Oct 4, 2022

Does not really check if it is in the right section though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0