8000 JP-2653: Fix IFU variance propagation in extract_1d by drlaw1558 · Pull Request #6892 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2653: Fix IFU variance propagation in extract_1d #6892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 21, 2022
Merged

JP-2653: Fix IFU variance propagation in extract_1d #6892

merged 5 commits into from
Jun 21, 2022

Conversation

drlaw1558
Copy link
Collaborator
@drlaw1558 drlaw1558 commented Jun 17, 2022 •
edited by hbushouse
Loading

Resolves JP-2653

Description

This PR fixes incorrect variance propagation for surface brightness computations in IFU Extract 1D.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@drlaw1558 drlaw1558 requested a review from hbushouse June 17, 2022 21:27
@codecov
Copy link
codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #6892 (2d180cb) into master (e30daef) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6892      +/-   ##
==========================================
- Coverage   79.36%   79.23%   -0.14%     
==========================================
  Files         418      418              
  Lines       37320    37765     +445     
==========================================
+ Hits        29619    29923     +304     
- Misses       7701     7842     +141
Flag< 8000 /th> Coverage Δ *Carryforward flag
nightly 79.35% <100.00%> (ø) Carriedforward from e30daef
unit 53.30% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/extract_1d/ifu.py 68.85% <100.00%> (-10.75%) ⬇️
jwst/associations/lib/rules_level3.py 96.59% <0.00%> (-2.00%) ⬇️
jwst/associations/lib/rules_level2b.py 95.75% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30daef...2d180cb. Read the comment docs.

@hbushouse hbushouse changed the title Drl varfix JP-2653: Fix IFU variance propagation in extract_1d Jun 21, 2022
@hbushouse hbushouse requested review from jemorrison and tapastro June 21, 2022 15:47
@hbushouse hbushouse added this to the Build 8.1 milestone Jun 21, 2022
hbushouse
hbushouse approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hbushouse hbushouse merged commit fc58b7a into spacetelescope:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@jemorrison jemorrison Awaiting requested review from jemorrison

@tapastro tapastro Awaiting requested review from tapastro

Assignees
No one assigned
Labels
extract_1d MIRI MRS
Projects
None yet
Milestone
Build 8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@drlaw1558 @hbushouse
0