8000 JP-2667: Fix calwebb_tso3 failure when checking for null results by hbushouse · Pull Request #6912 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2667: Fix calwebb_tso3 failure when checking for null results #6912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2022
Merged

JP-2667: Fix calwebb_tso3 failure when checking for null results #6912

merged 2 commits into from
Jul 6, 2022

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented Jul 6, 2022 •
edited
Loading

Resolves JP-2667

Description

This PR makes a change to the logic used near the end of the pipeline to check for all null results coming back from either the tso_photometry or white_light steps. A recent numpy update (1.23.0) changed a FutureWarning to an actual error, related to the behavior of astropy.tables objects. The new, simpler logic works with numpy 1.23 and is backwards compatible with previous versions.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@hbushouse hbushouse added this to the Build 8.1 milestone Jul 6, 2022
tapastro
tapastro approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor
@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hbushouse
Copy link
Collaborator Author

CI failures are due to the recent NIRSpec ref file updates (unrelated).

@hbushouse hbushouse merged commit f6d5c56 into spacetelescope:master Jul 6, 2022
@hbushouse hbushouse deleted the jp2667 branch July 6, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

@tapastro tapastro tapastro approved these changes

Assignees
No one assigned
Labels
bug tso3 pipeline
Projects
None yet
Milestone
Build 8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@hbushouse @stscieisenhamer @tapastro
0