8000 Document calculation of readnoise variance (JP-2670) by dmggh · Pull Request #6924 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Document calculation of readnoise variance (JP-2670) #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2022
Merged

Document calculation of readnoise variance (JP-2670) #6924

merged 5 commits into from
Jul 19, 2022

Conversation

dmggh
Copy link
Contributor
@dmggh dmggh commented Jul 14, 2022 •
edited by hbushouse
Loading

Resolves JP-2670

This PR documents the derivation of the calculation of the readnoise variance described in the Segment-specific Computations

Checklist

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)

@dmggh dmggh requested a review from hbushouse July 14, 2022 06:42
@dmggh dmggh self-assigned this Jul 14, 2022
@codecov
Copy link
codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #6924 (b4c55cf) into master (bf606c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6924   +/-   ##
=======================================
  Coverage   79.33%   79.33%           
=======================================
  Files         414      414           
  Lines       37234    37234           
=======================================
  Hits        29539    29539           
  Misses       7695     7695
Flag Coverage Δ *Carryforward flag
nightly 79.31% <ø> (ø) Carriedforward from bf606c8
unit 53.14% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf606c8...b4c55cf. Read the comment docs.

hbushouse
hbushouse reviewed Jul 15, 2022
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just a couple minor comments.

@hbushouse hbushouse merged commit 2b3e92a into master Jul 19, 2022
@hbushouse hbushouse deleted the JP-2670 branch July 19, 2022 12:14
tapastro pushed a commit to tapastro/jwst that referenced this pull request Jul 26, 2022
@dmggh @tapastro
Document calculation of readnoise variance (JP-2670) (spacetelescope#…
45373ed 
…6924)

* Document calculation of readnoise variance

* Document calculation of readnoise variance

* minor corrections based on review suggestions

* minor corrections based on review suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees

@dmggh dmggh

Labels
documentation ramp_fitting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmggh @hbushouse
0