8000 Update NIS_SOSS regtest with in-flight data by hbushouse · Pull Request #6926 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update NIS_SOSS regtest with in-flight data #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2022
Merged

Update NIS_SOSS regtest with in-flight data #6926

merged 1 commit into from
Jul 15, 2022

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented Jul 15, 2022 •
edited
Loading

This PR addresses updates our regression test of NIRISS SOSS data to use in-flight data. The data itself consists of an exposure that has been segmented (which is usually the case for TSO data), where I'm including just the first 2 segments and have also trimmed down the data in each segment to only contain 10 integrations each (originally 190 each), just to save processing time.

The necessary input and truth files have already been uploaded to artifactory.

Checklist

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)

@codecov
Copy link
codecov bot commented Jul 15, 2022 •
edited
Loading

Codecov Report

Merging #6926 (efb0977) into master (ad99335) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6926   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files         414      414           
  Lines       37212    37212           
=======================================
  Hits        29081    29081           
  Misses       8131     8131
Flag Coverage Δ *Carryforward flag
nightly 78.13% <ø> (ø) Carriedforward from ad99335
unit 53.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad99335...efb0977. Read the comment docs.

tapastro
tapastro approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor
@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit e52e7f6 into spacetelescope:master Jul 15, 2022
@hbushouse hbushouse deleted the soss_regtest branch July 15, 2022 14:30
tapastro pushed a commit to tapastro/jwst that referenced this pull request Jul 26, 2022
@hbushouse @tapastro
Update NIS_SOSS regtest with in-flight data (spacetelescope#6926)
94db1d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapastro tapastro tapastro approved these changes

@stscieisenhamer stscieisenhamer Awaiting requested review from stscieisenhamer

Assignees
No one assigned
Labels
no-changelog-entry-needed regression-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbushouse @tapastro
0