8000 JP-2686: Support user-supplied reference files for stage 2 of WCS alignment by mcara · Pull Request #6946 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2686: Support user-supplied reference files for stage 2 of WCS alignment #6946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2022
Merged

JP-2686: Support user-supplied reference files for stage 2 of WCS alignment #6946

merged 3 commits into from
Aug 12, 2022

Conversation

mcara
Copy link
Member
@mcara mcara commented Jul 28, 2022

Resolves JP-2686

This PR add support for user-specified reference astrometric catalogs to be used in place of GAIADR1 or GAIADR2 catalogs.

Checklist

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)

@mcara mcara added this to the Build 8.2 milestone Jul 28, 2022
@mcara mcara requested review from nden, stsci-hack and hbushouse July 28, 2022 00:53
@mcara mcara self-assigned this Jul 28, 2022
@mcara mcara force-pushed the tweakreg-allow-refcat branch from 5317a05 to 01a243b Compare July 28, 2022 04:26
@codecov
Copy link
codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #6946 (d12c216) into master (abd9b56) will decrease coverage by 0.02%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##           master    #6946      +/-   ##
==========================================
- Coverage   79.27%   79.24%   -0.03%     
==========================================
  Files         414      414              
  Lines       37459    37567     +108     
==========================================
+ Hits        29695    29771      +76     
- Misses       7764     7796      +32
Flag Coverage Δ *Carryforward flag
nightly 79.24% <90.00%> (ø) Carriedforward from abd9b56
unit 53.11% <47.61%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/tweakreg/tweakreg_step.py 65.54% <64.28%> (+2.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hbushouse hbushouse modified the milestones: Build 8.2, Build 9.0 Aug 5, 2022
@hbushouse hbushouse added the 8.1 patch PR candidate for an 8.1 patch release label Aug 5, 2022
@mcara mcara force-pushed the tweakreg-allow-refcat branch from 01a243b to f6297c8 Compare August 5, 2022 18:46
@mcara mcara requested a review from mairanteodoro August 9, 2022 21:16
@mcara mcara force-pushed the tweakreg-allow-refcat branch from f6297c8 to f0da190 Compare August 9, 2022 21:22
@mcara mcara requested a review from cshanahan1 August 9, 2022 21:29
hbushouse
hbushouse reviewed Aug 10, 2022
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough. Just one minor comment regarding a typo.

stsci-hack
stsci-hack reviewed Aug 10, 2022
View reviewed changes
hbushouse
hbushouse reviewed Aug 12, 2022
View reviewed changes
@mcara mcara force-pushed the tweakreg-allow-refcat branch from 2fbab24 to d12c216 Compare August 12, 2022 18:03
@hbushouse hbushouse merged commit 0876621 into spacetelescope:master Aug 12, 2022
zacharyburnett pushed a commit to zacharyburnett/jwst that referenced this pull request Aug 31, 2022
@mcara @zacharyburnett
JP-2686: Support user-supplied reference files for stage 2 of WCS ali…
a9dc2a6 
…gnment (spacetelescope#6946)

* Support user-supplied reference files for stage 2 of WCS alignment

* Update error message text

* Generalize list of supported built-in refcat

(cherry picked from commit 0876621)
@mcara mcara mentioned this pull request Sep 3, 2022
Merged
6 tasks
@hbushouse hbushouse modified the milestones: Build 9.0, Build 8.1.2 Sep 7, 2022
@mcara mcara deleted the tweakreg-allow-refcat branch April 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsci-hack stsci-hack stsci-hack left review comments

@hbushouse hbushouse hbushouse approved these changes

@nden nden Awaiting requested review from nden

@mairanteodoro mairanteodoro Awaiting requested review from mairanteodoro

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1

Assignees

@mcara mcara

Labels
8.1 patch PR candidate for an 8.1 patch release documentation enhancement tweakreg
Projects
None yet
Milestone
Build 8.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mcara @stsci-hack @hbushouse
0