8000 Add P_SUBARR to the DarkModel schema (JP-2656) by dmggh · Pull Request #6951 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add P_SUBARR to the DarkModel schema (JP-2656) #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Add P_SUBARR to the DarkModel schema (JP-2656) #6951

merged 2 commits into from
Jul 29, 2022

Conversation

dmggh
Copy link
Contributor
@dmggh dmggh commented Jul 28, 2022

Resolves JP-2656

Closes #2656

This PR simplifies the creation of reference files regarding multiple subarray values, by adding the ability to add these values into the header of the file when using the DarkModel.

Checklist

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)

@dmggh dmggh added datamodels keywords Anything related to FITS header keywords labels Jul 28, 2022
@dmggh dmggh added this to the Build 9.0 milestone Jul 28, 2022
@dmggh dmggh self-assigned this Jul 28, 2022
@codecov
Copy link
codecov bot commented Jul 28, 2022

Codecov Report

Merging #6951 (54b4a15) into master (8258193) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6951   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files         414      414           
  Lines       37365    37365           
=======================================
  Hits        29686    29686           
  Misses       7679     7679           
Flag Coverage Δ *Carryforward flag
nightly 79.43% <ø> (ø) Carriedforward from 8258193
unit 53.21% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8258193...54b4a15. Read the comment docs.

@dmggh dmggh merged commit 80085f6 into master Jul 29, 2022
@hbushouse hbushouse modified the milestones: Build 9.0, Build 8.1.2 Sep 7, 2022
@tapastro tapastro deleted the JP-2656 branch September 20, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodels keywords Anything related to FITS header keywords
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MSA metadata file handling for new primary_source column
3 participants
0