Revert Fourier Transform code to avoid Poppy's recently updated sign convention (JP-2618) #6967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbushouse
reviewed
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #6967 +/- ##
==========================================
- Coverage 79.44% 79.37% -0.07%
==========================================
Files 414 415 +1
Lines 37369 37463 +94
==========================================
+ Hits 29689 29738 +49
- Misses 7680 7725 +45
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
A regression test run against this branch shows what I assume are expected differences in the ami_analyze outputs (https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/372/#showFailuresLink) and the one unit test failure due to the doc string problem that's also killing the CI tests here. So once that unit test gets fixed, this should be good to go. |
hbushouse
approved these changes
Aug 8, 2022
zacharyburnett
pushed a commit
to zacharyburnett/jwst
that referenced
this pull request
Aug 31, 2022
…convention (JP-2618) (spacetelescope#6967) * Revert Fourier Transform code to avoid Poppy's recently updated sign convertion * Updated PR number * Reconcile arg list * Delete example in docs (cherry picked from commit 495831c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poppy was recently updated to change the sign convention used in exponents in the Fourier transform calculation. This update reverts the ami_analyze code to use an earlier code, in the matrix_dft.py module.
Resolves JP-2618
Checklist
CHANGES.rstwithin the relevant release section