8000 JP-2797: MRS sigma-clipped master background fix by drlaw1558 · Pull Request #6960 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2797: MRS sigma-clipped master background fix #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2022
Merged

JP-2797: MRS sigma-clipped master background fix #6960

merged 2 commits into from
Aug 4, 2022

Conversation

drlaw1558
Copy link
Collaborator
@drlaw1558 drlaw1558 commented Aug 2, 2022 •
edited by hbushouse
Loading

This PR fixes an issue where the sigma-clipped background isn't being used as intended for the master background step when the source type is undefined (see https://jira.stsci.edu/browse/JP-2797)

Checklist

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)

@codecov
Copy link
codecov bot commented Aug 2, 2022 •
edited
Loading

Codecov Report

Merging #6960 (2034f27) into master (deaf84e) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #6960      +/-   ##
==========================================
- Coverage   79.46%   79.43%   -0.03%     
==========================================
  Files         414      414              
  Lines       37427    37470      +43     
==========================================
+ Hits        29743    29766      +23     
- Misses       7684     7704      +20
Flag Coverage Δ *Carryforward flag
nightly 79.41% <100.00%> (ø) Carriedforward from deaf84e
unit 53.20% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/master_background/master_background_step.py 70.32% <66.66%> (-5.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deaf84e...2034f27. Read the comment docs.

@stscieisenhamer
Copy link
Collaborator

FYI: The unrelated code style issues are being handled in another issue. No need to repair in this PR.

@hbushouse hbushouse added this to the Build 9.0 milestone Aug 4, 2022
@hbushouse hbushouse added the 8.1 patch PR candidate for an 8.1 patch release label Aug 4, 2022
hbushouse
hbushouse approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and simple enough) to me.

@hbushouse
Copy link
Collaborator

CI failures are unrelated.

@hbushouse hbushouse changed the title MRS sigma-clipped master background fix JP-2797: MRS sigma-clipped master background fix Aug 4, 2022
@hbushouse hbushouse merged commit 9774566 into spacetelescope:master Aug 4, 2022
zacharyburnett pushed a commit to zacharyburnett/jwst that referenced this pull request Aug 31, 2022
@drlaw1558 @zacharyburnett
JP-2797: MRS sigma-clipped master background fix (spacetelescope#6960)
8dee063 
* MRS background fix

* Add PR number to change log

(cherry picked from commit 9774566)
@hbushouse hbushouse modified the milestones: Build 9.0, Build 8.1.2 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@jemorrison jemorrison Awaiting requested review from jemorrison

Assignees
No one assigned
Labels
8.1 patch PR candidate for an 8.1 patch release master_background
Projects
None yet
Milestone
Build 8.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@drlaw1558 @stscieisenhamer @hbushouse
0