JP-2704 MIRI MRS Failures in Cube when there is no valid data on rate/cal image #6998
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6998 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 411 411
Lines 37197 37217 +20
=======================================
+ Hits 29600 29616 +16
- Misses 7597 7601 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Looks ok to me; tested that it fixes the crash that we were seeing in https://jira.stsci.edu/browse/JP-2704
There was a problem hiding this comment.
So what happens when there's no good data and this function returns a list of None values? I assume the higher-level calling routines are already setup to handle that and skip the creation of an s3d file? And the pipeline flow also properly recognizes that no s3d was created and hence the extract_1d step also gets skipped?
|
I checked and if running in calspec2 and all the wavelength planes in a cube have zero data, then a log.error message is given. No IFU cube is created and the extract1d step is skipped. |
…/cal image (spacetelescope#6998) * check if no data is mapped * updates to ifu_cube when DO_NOT_USE is set for most of data * update change log (cherry picked from commit dc52c6e)
Resolves JP-2704
This PR addresses when no valid data is found on the detector because all the pixels are marked as DO_NOT_USE.
An additional bug fix was made for correctly updating the naxis3 value of the final cube when wavelength planes are removed from the IFUCube because they contain no valid data.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/398/