8000 Update code to use tweakwcs 0.8.0 by mcara · Pull Request #7006 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update code to use tweakwcs 0.8.0 #7006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

mcara
Copy link
Member
@mcara mcara commented Aug 29, 2022

This PR updates code that uses tweakwcs to use newest classes instead of the deprecated ones. For a full list of changes in tweakwcs 0.8.0 - see https://github.com/spacetelescope/tweakwcs/releases/tag/0.8.0. Most changes are about changing class and module names to better represent what they actually do.

This PR updates drizzlepac code in order to avoid deprecation warnings.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Regression test link: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/402/

@mcara mcara added tweakreg dependencies Pull requests that update a dependency file labels Aug 29, 2022
@mcara mcara added this to the Build 9.0 milestone Aug 29, 2022
@mcara mcara requested review from stsci-hack and hbushouse August 29, 2022 06:14
@mcara mcara self-assigned this Aug 29, 2022
@codecov
Copy link
codecov bot commented Aug 29, 2022

Codecov Report

Merging #7006 (99c0e37) into master (c646fc1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7006   +/-   ##
=======================================
  Coverage   79.68%   79.68%           
=======================================
  Files         411      411           
  Lines       37226    37226           
=======================================
  Hits        29662    29662           
  Misses       7564     7564           
Flag Coverage Δ
nightly 79.64% <100.00%> (ø)
unit 53.23% <80.00%> (ø)
Impacted Files Coverage Δ
jwst/tweakreg/tweakreg_step.py 63.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mcara
Copy link
Member Author
mcara commented Aug 29, 2022

Failures in the regression tests are unrelated to this PR

Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcara mcara merged commit d6782fb into spacetelescope:master Aug 29, 2022
@hbushouse hbushouse added the 8.1 patch PR candidate for an 8.1 patch release label Aug 31, 2022
zacharyburnett pushed a commit to zacharyburnett/jwst that referenced this pull request Aug 31, 2022
@hbushouse hbushouse modified the milestones: Build 9.0, Build 8.1.2 Sep 7, 2022
@mcara mcara deleted the require-tweakwcs-0.8.0 branch April 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1 patch PR candidate for an 8.1 patch release dependencies Pull requests that update a dependency file installation testing tweakreg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0