8000 Set DQ of ref pixels to DO_NOT_USE after refpix correction by jdavies-st · Pull Request #7017 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set DQ of ref pixels to DO_NOT_USE after refpix correction #7017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Set DQ of ref pixels to DO_NOT_USE after refpix correction #7017

wants to merge 1 commit into from

Conversation

jdavies-st
Copy link
Collaborator
@jdavies-st jdavies-st commented Sep 2, 2022 •
edited
Loading

Closes #7015

This PR addresses the current fragility of how reference pixels are set to DO_NOT_USE in calwebb_detector1. Currently they rely on the GAIN reference file having zeros in the reference pixel locations, and then ramp_fitting sets those pixels to DO_NOT_USE in the science data DQ.

This PR sets the DQ of reference pixels to DO_NOT_USE at the end of the refpix step. It does require that DQInitStep label these properly as REFERENCE_PIXELS, but this seems to be the case currently for the currently selected MASK reference files for all instruments.

Is this the best way to do this? Thoughts?

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@jdavies-st jdavies-st force-pushed the refpix-posthook-do-not-use branch from 4792cc5 to 8dbe419 Compare September 2, 2022 12:33
@codecov
Copy link
codecov bot commented Sep 2, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (e2284d1) to head (21fd546).
Report is 2039 commits behind head on main.

Files with missing lines Patch % Lines
jwst/refpix/reference_pixels.py 94.73% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7017      +/-   ##
==========================================
+ Coverage   78.60%   78.71%   +0.11%     
==========================================
  Files         455      455              
  Lines       39148    39431     +283     
==========================================
+ Hits        30771    31039     +268     
- Misses       8377     8392      +15
Flag Coverage Δ *Carryforward flag
nightly 78.59% <92.85%> (ø) Carriedforward from e2284d1
unit 51.41% <85.71%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdavies-st jdavies-st force-pushed the refpix-posthook-do-not-use branch from 8dbe419 to 938a766 Compare September 5, 2022 12:09
@jdavies-st jdavies-st force-pushed the refpix-posthook-do-not-use branch from 938a766 to 77e6f86 Compare October 28, 2022 09:38
@jdavies-st jdavies-st force-pushed the refpix-posthook-do-not-use branch from 77e6f86 to 21fd546 Compare January 17, 2023 08:58
@nden nden requested a review from hbushouse June 26, 2023 21:19
@jdavies-st jdavies-st requested a review from a team as a code owner March 28, 2024 13:52
zacharyburnett
zacharyburnett requested changes Sep 23, 2024
View reviewed changes
CHANGES.rst
Comment on lines +580 to +584
refpix
------

- Set DQ of ref pixels to DO_NOT_USE after `refpix` correction [#7017]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
refpix
------
- Set DQ of ref pixels to DO_NOT_USE after `refpix` correction [#7017]

now that #8671 is merged (switching change log handling to towncrier) this change log entry should be a file in changes/ instead:

echo "Set DQ of ref pixels to ``DO_NOT_USE`` after ``refpix`` correction" > changes/7017.refpix.rst

(new PRs will include instructions on how to do this)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ignore this if this PR is no longer active or needed)

@hbushouse hbushouse removed their request for review September 23, 2024 18:37
@melanieclarke
Copy link
Collaborator

I'm going to close this PR since it's now very out of sync with main.

The issue is still tracked in JP-3703 and #7015. If INS decides this change is desirable, we can make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett requested changes

Assignees
No one assigned
Labels
documentation refpix testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference pixels set to DO_NOT_USE in DQ is fragile
3 participants
@jdavies-st @melanieclarke @zacharyburnett
0