8000 Fix failing regression test due to gaia->abs name changes by mcara · Pull Request #7029 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix failing regression test due to gaia->abs name changes #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix failing regression test due to gaia->abs name changes #7029

merged 1 commit into from
Sep 7, 2022

Conversation

mcara
Copy link
Member
@mcara mcara commented Sep 7, 2022 •
edited by hbushouse
Loading

Fixes failing tests reported in #7023 (comment)

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Regression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/418/
8000

@mcara mcara requested a review from hbushouse September 7, 2022 16:29
@mcara mcara self-assigned this Sep 7, 2022
@hbushouse hbushouse added this to the Build 8.1.2 milestone Sep 7, 2022
@codecov
Copy link
codecov bot commented Sep 7, 2022 •
edited
Loading

Codecov Report

Base: 79.54% // Head: 79.59% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (de1efa2) compared to base (7af3eaa).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7029      +/-   ##
==========================================
+ Coverage   79.54%   79.59%   +0.05%     
==========================================
  Files         411      411              
  Lines       37271    37271              
==========================================
+ Hits        29646    29665      +19     
+ Misses       7625     7606      -19
Flag Coverage Δ
nightly 79.57% <ø> (+0.05%) ⬆️
unit 53.23% <ø> (ø)
Impacted Files Coverage Δ
jwst/regtest/regtestdata.py 84.86% <0.00%> (-0.46%) ⬇️
jwst/tweakreg/astrometric_utils.py 88.52% <0.00%> (+1.63%) ⬆️
jwst/tweakreg/tweakreg_step.py 64.42% <0.00%> (+9.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hbushouse
hbushouse approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regtest results are good, CI tests are good. Looks good to me!

@hbushouse hbushouse merged commit 881f3ab into spacetelescope:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees

@mcara mcara

Labels
documentation NIRCAM regression_testing regression-test tests
Projects
None yet
Milestone
Build 8.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mcara @hbushouse
0