8000 Fix handling of ASN directory path by the ModelContainer by mcara · Pull Request #7071 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix handling of ASN directory path by the ModelContainer #7071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2022
Merged

Fix handling of ASN directory path by the ModelContainer #7071

merged 1 commit into from
Oct 14, 2022

Conversation

mcara
Copy link
Member
@mcara mcara commented Oct 14, 2022 •
edited
Loading

Fixes a bug introduced by #7022

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@mcara mcara requested a review from hbushouse October 14, 2022 21:01
@mcara mcara requested a review from zacharyburnett October 14, 2022 21:02
@mcara mcara force-pushed the fix-custom-cat-asn-container branch from bf6cf92 to 049f01c Compare October 14, 2022 21:03
@mcara mcara self-assigned this Oct 14, 2022
@mcara mcara added the bug label Oct 14, 2022
@mcara mcara added this to the Build 9.0 milestone Oct 14, 2022
@mcara mcara force-pushed the fix-custom-cat-asn-container branch from 049f01c to 953417f Compare October 14, 2022 21:16
@zacharyburnett zacharyburnett enabled auto-merge (squash) October 14, 2022 21:24
zacharyburnett
zacharyburnett approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator
@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, will merge as soon as the unit tests pass

@codecov
Copy link
codecov bot commented Oct 14, 2022

Codecov Report

Base: 79.37% // Head: 79.40% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (953417f) compared to base (d7fa8d6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7071      +/-   ##
==========================================
+ Coverage   79.37%   79.40%   +0.02%     
==========================================
  Files         412      412              
  Lines       37385    37385              
==========================================
+ Hits        29676    29687      +11     
+ Misses       7709     7698      -11
Flag Coverage Δ *Carryforward flag
nightly 79.37% <100.00%> (ø) Carriedforward from d7fa8d6
unit 51.92% <100.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/associations/lib/dms_base.py 90.34% <100.00%> (ø)
jwst/datamodels/container.py 79.92% <100.00%> (ø)
jwst/regtest/conftest.py 64.67% <0.00%> (+0.54%) ⬆️
jwst/lib/engdb_direct.py 100.00% <0.00%> (+0.86%) ⬆️
jwst/stpipe/utilities.py 95.65% <0.00%> (+4.34%) ⬆️
jwst/lib/engdb_tools.py 100.00% <0.00%> (+6.66%) ⬆️
jwst/assign_mtwcs/moving_target_wcs.py 86.79% <0.00%> (+11.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett merged commit c3a4a05 into spacetelescope:master Oct 14, 2022
@mcara mcara mentioned this pull request Oct 15, 2022
Closed
@mcara mcara deleted the fix-custom-cat-asn-container branch April 8, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

@hbushouse hbushouse Awaiting requested review from hbushouse

Assignees

@mcara mcara

Labels
bug datamodels
Projects
None yet
Milestone
Build 9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcara @zacharyburnett
0