8000 Add note about source catalog pixel indexing by larrybradley · Pull Request #7300 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add note about source catalog pixel indexing #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

larrybradley
Copy link
Member
@larrybradley larrybradley commented Oct 19, 2022

This PR updates the docs to add a note about the source catalog centroid pixel indexing. I've also added this to the column descriptions in the output catalog metadata. A few users (e.g., help desk tickets) have been confused about the pixel indexing.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link
codecov bot commented Oct 19, 2022

Codecov Report

Base: 79.41% // Head: 79.41% // No change to project coverage 👍

Coverage data is based on head (e87bf5e) compared to base (3a1a35a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7300   +/-   ##
=======================================
  Coverage   79.41%   79.41%           
=======================================
  Files         412      412           
  Lines       37392    37392           
=======================================
  Hits        29696    29696           
  Misses       7696     7696           
Flag Coverage Δ *Carryforward flag
nightly 79.39% <100.00%> (ø) Carriedforward from 3a1a35a
unit 51.93% <100.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/source_catalog/source_catalog.py 98.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mcara mcara merged commit 450fc0a into spacetelescope:master Oct 19, 2022
@larrybradley larrybradley deleted the cat-pix-idx branch October 19, 2022 03:54
@hbushouse
Copy link
Collaborator

@zacharyburnett Can you confirm that this PR was NOT included in the 1.8.1 release created on 17-Oct-2022 (just for the purpose of record keeping)?

@hbushouse hbushouse added this to the Build 9.1 milestone Oct 19, 2022
@zacharyburnett
Copy link
Collaborator

yes, it was not included:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0