JP-2802: Fix a bug in the definition of NIRSpec resampled WCS #7359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 79.64% // Head: 79.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7359 +/- ##
==========================================
- Coverage 79.64% 79.57% -0.07%
==========================================
Files 412 412
Lines 37572 37730 +158
==========================================
+ Hits 29924 30025 +101
- Misses 7648 7705 +57
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e2bb2cc to
38bdbcf
Compare
hbushouse
approved these changes
Nov 21, 2022
38bdbcf to
e508f9e
Compare
e508f9e to
43208ed
Compare
|
The CI failure appears to be unrelated, so I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-2802
Closes #7265
This PR fixes a bug in the definition of the NIRSpec resampled WCS. Fundamentally, the bug was that for the forward transformation the horizontal position in the slit was incorrect. This PR fixes horizontal position to 0 - center of the slit. I expect regression tests to fail.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR
Regression test: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/469/