8000 JP-2984: Update ASN rules for NIS_WFSS to keep grisms separate by hbushouse · Pull Request #7351 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2984: Update ASN rules for NIS_WFSS to keep grisms separate #7351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 16, 2022
Merged

JP-2984: Update ASN rules for NIS_WFSS to keep grisms separate #7351

merged 4 commits into from
Nov 16, 2022

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented Nov 15, 2022 •
edited
Loading

Resolves JP-2984

Closes #7315

This PR makes a trivial change to the NIRISS WFSS level-3 ASN rule so that unique ASN's and products are created for each of the gr150r and gr150c grisms.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse hbushouse added this to the Build 9.1 milestone Nov 15, 2022
@codecov
Copy link
codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

Base: 79.68% // Head: 79.68% // No change to project coverage 👍

Coverage data is based on head (2e7a713) compared to base (1b8d288).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7351   +/-   ##
=======================================
  Coverage   79.68%   79.68%           
=======================================
  Files         412      412           
  Lines       37573    37573           
=======================================
  Hits        29941    29941           
  Misses       7632     7632
Flag Coverage Δ *Carryforward flag
nightly 79.66% <ø> (ø) Carriedforward from 1b8d288
unit 52.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/associations/lib/rules_level3.py 98.65% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse
Copy link
Collaborator Author

Re 8000 gression test results are here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/463/

2 failures (nirspec_ifu) are unrelated. The other 4 are all as expected, where formerly it was creating product names with optical elements of "-gr150c-gr150r" and now there are separate "-gr150c" and "-gr150r" products.

@hbushouse
Copy link
Collaborator Author

CI failures are the usual random glitches in file access.

tapastro
tapastro approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor
@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

stscieisenhamer
stscieisenhamer approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator
@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides a rebase to fix the changelog, LGTM.

@hbushouse hbushouse merged commit 1f4255f into spacetelescope:master Nov 16, 2022
@hbushouse hbushouse deleted the jp-2984 branch November 16, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

@tapastro tapastro tapastro approved these changes

@kmacdonald-stsci kmacdonald-stsci Awaiting requested review from kmacdonald-stsci

Assignees
No one assigned
Labels
associations testing
Projects
None yet
Milestone
Build 9.1
Development

Successfully merging this pull request may close these issues.

Create separate spec3 ASN's for each WFSS grism orientation
3 participants
@hbushouse @stscieisenhamer @tapastro
0