8000 (JP-3002) Add SUB400X256ALWB subarray to NIRCam allowed values by dmggh · Pull Request #7361 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

(JP-3002) Add SUB400X256ALWB subarray to NIRCam allowed values #7361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2022
Merged

(JP-3002) Add SUB400X256ALWB subarray to NIRCam allowed values #7361

merged 2 commits into from
Nov 21, 2022

Conversation

dmggh
Copy link
Contributor
@dmggh dmggh commented Nov 17, 2022 •
edited by hbushouse
Loading

Resolves JP-3002

This PR adds the SUB400X256ALWB subarray to the NIRCam allowed values. This subarray will replace the subarray SUB320ALWB, which is moved to the 'obsolete' section, as we probably will have data with this obsolete name and so want to keep it.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@dmggh dmggh added the NIRCAM label Nov 17, 2022
@dmggh dmggh added this to the Build 9.1 milestone Nov 17, 2022
@dmggh dmggh requested a review from hbushouse November 17, 2022 23:21
@dmggh dmggh self-assigned this Nov 17, 2022
@codecov
Copy link
codecov bot commented Nov 18, 2022 •
edited
Loading

Codecov Report

Base: 79.68% // Head: 79.71% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (c3f08aa) compared to base (0a9a720).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7361      +/-   ##
==========================================
+ Coverage   79.68%   79.71%   +0.02%     
==========================================
  Files         412      412              
  Lines       37573    37617      +44     
==========================================
+ Hits        29941    29985      +44     
  Misses       7632     7632
Flag Coverage Δ *Carryforward flag
nightly 79.66% <ø> (ø) Carriedforward from 0a9a720
unit 52.23% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/associations/mkpool.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hbushouse
hbushouse approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit 5dcff8a into spacetelescope:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees

@dmggh dmggh

Labels
datamodels
Projects
None yet
Milestone
Build 9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dmggh @hbushouse
0