10000 JP-3034: Change import for photutils CircularAnnulus by hbushouse · Pull Request #7407 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-3034: Change import for photutils CircularAnnulus #7407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

JP-3034: Change import for photutils CircularAnnulus #7407

merged 2 commits into from
Dec 21, 2022

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented Dec 20, 2022 •
edited
Loading

Resolves JP-3034

This PR changes the import for several photutils routines, to keep up with changes in the photutils pkg.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse hbushouse added this to the Build 9.1 milestone Dec 20, 2022
@codecov
Copy link
codecov bot commented Dec 20, 2022 •
edited
Loading

Codecov Report

Base: 76.19% // Head: 76.19% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (8833045) compared to base (f8cd884).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7407      +/-   ##
==========================================
- Coverage   76.19%   76.19%   -0.01%     
==========================================
  Files         417      417              
  Lines       37984    38045      +61     
==========================================
+ Hits        28942    28987      +45     
- Misses       9042     9058      +16
Flag Coverage Δ *Carryforward flag
nightly 76.17% <100.00%> (ø) Carriedforward from b442906
unit 52.06% <100.00%> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/outlier_detection/outlier_detection_scaled.py 20.00% <100.00%> (ø)
jwst/associations/asn_edit.py 66.66% <0.00%> (-0.75%) ⬇️
jwst/model_blender/blendmeta.py 83.05% <0.00%> (-0.71%) ⬇️
jwst/ami/lg_model.py 62.03% <0.00%> (-0.34%) ⬇️
jwst/refpix/irs2_subtract_reference.py 83.97% <0.00%> (-0.30%) ⬇️
jwst/ami/utils.py 87.96% <0.00%> (-0.29%) ⬇️
jwst/ami/nrm_core.py 20.61% <0.00%> (-0.28%) ⬇️
jwst/fits_generator/template.py 16.98% <0.00%> (-0.27%) ⬇️
jwst/persistence/persistence.py 80.42% <0.00%> (-0.19%) ⬇️
jwst/transforms/models.py 94.00% <0.00%> (-0.12%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse
Copy link
Collaborator Author

Regression test run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/509/testReport/ shows only unrelated failures.

@hbushouse hbushouse merged commit 1130151 into spacetelescope:master Dec 21, 2022
@hbushouse hbushouse deleted the jp-3034 branch December 21, 2022 13:56
@nden
Copy link
Collaborator
nden commented Dec 21, 2022

Does this require bumping the min photutils version in setup.cfg?

@hbushouse
Copy link
Collaborator Author

Does this require bumping the min photutils version in setup.cfg?

I assume not, because we were already getting the deprecation warning from the current version. And I see the same changes to imports (for the same photutils functions) were made a while ago already in the source_catalog and tso_photometry steps and that did not require a bump in photutils version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stscieisenhamer stscieisenhamer stscieisenhamer approved these changes

@larrybradley larrybradley Awaiting requested review from larrybradley

Assignees
No one assigned
Labels
outlier_detection
Projects
None yet
Milestone
Build 9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@hbushouse @nden @stscieisenhamer
0