8000 update reference values for approximation test after GWCS SIP fit change by zacharyburnett · Pull Request #7415 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update reference values for approximation test after GWCS SIP fit change #7415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 23, 2022
Merged

update reference values for approximation test after GWCS SIP fit change #7415

merged 5 commits into from
Dec 23, 2022

Conversation

zacharyburnett
Copy link
Collaborator
@zacharyburnett zacharyburnett commented Dec 23, 2022 •
edited
Loading

related to spacetelescope/gwcs#427

This PR addresses test failures in test_sip_approx after the GWCS change in spacetelescope/gwcs#427 by updating the true_wcs reference values. Alternatively, the absolute tolerance can be changed from 1e-10 to 5e-3 to make the test pass:

- assert_allclose(true_wcs[key], wcs_info[key], rtol=2e-4, atol=1e-10)
+ assert_allclose(true_wcs[key], wcs_info[key], rtol=2e-4, atol=5e-3)

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Dec 23, 2022
@codecov
Copy link
codecov bot commented Dec 23, 2022 •
edited
Loading

Codecov Report

Base: 80.05% // Head: 80.05% // No change to project coverage 👍

Coverage data is based on head (85f2301) compared to base (0f3b843).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7415   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files         417      417           
  Lines       38087    38087           
=======================================
  Hits        30489    30489           
  Misses       7598     7598
Flag Coverage Δ *Carryforward flag
nightly 80.04% <ø> (ø) Carriedforward from 0f3b843
unit 52.10% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett requested review from nden and mcara and removed request for mcara December 23, 2022 19:15
@zacharyburnett zacharyburnett changed the title update reference values for approximation test after GWCS SIP update update reference values for approximation test after GWCS SIP fit change Dec 23, 2022
@nden
Copy link
Collaborator
nden commented Dec 23, 2022

May be change the absolute tolerance in line 264 to
assert_allclose(true_wcs[key], wcs_info[key], rtol=2e-4, atol=1e-9)

@zacharyburnett zacharyburnett marked this pull request as ready for review December 23, 2022 20:01
@nden nden merged commit 4e40f25 into spacetelescope:master Dec 23, 2022
@mcara
Copy link
Member
mcara commented Dec 23, 2022

I do not understand why there was need to relax rtol and atol if reference values have been updated.

@zacharyburnett zacharyburnett deleted the test_sip_approx_values branch December 24, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
assign_wcs installation no-changelog-entry-needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharyburnett @nden @mcara
0