10000 Merge the two update_wcsinfo functions into one by mcara · Pull Request #7412 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Merge the two update_wcsinfo functions into one #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2022
Merged

Merge the two update_wcsinfo functions into one #7412

merged 1 commit into from
Dec 23, 2022

Conversation

mcara
Copy link
Member
@mcara mcara commented Dec 22, 2022 •
edited by hbushouse
Loading

Resolves JP-3073

This PR merges fits_wcsinfo and update_fits_wcsinfo functions (fits_wcsinfo introduced in #7373) into a single function, basically expanding capabilities of the original update_fits_wcsinfo function.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@mcara mcara added this to the Build 9.1 milestone Dec 22, 2022
@mcara mcara requested review from nden and hbushouse December 22, 2022 16:57
@mcara mcara self-assigned this Dec 22, 2022
@mcara mcara force-pushed the merge-fits-wcsinfo branch from ab164c4 to 453ee21 Compare December 22, 2022 16:59
@codecov
Copy link
codecov bot commented Dec 22, 2022 •
edited
Loading

Codecov Report

Base: 52.52% // Head: 76.31% // Increases project coverage by +23.79% 🎉

Coverage data is based on head (453ee21) compared to base (b86454b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7412       +/-   ##
===========================================
+ Coverage   52.52%   76.31%   +23.79%     
===========================================
  Files         417      417               
  Lines       38087    38083        -4     
===========================================
+ Hits        20006    29064     +9058     
+ Misses      18081     9019     -9062
Flag Coverage Δ
nightly 76.30% <100.00%> (+57.37%) ⬆️
unit 52.10% <100.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
jwst/assign_wcs/util.py 83.86% <100.00%> (+9.93%) ⬆️
jwst/datamodels/util.py 87.17% <0.00%> (+0.42%) ⬆️
jwst/associations/association.py 91.66% <0.00%> (+0.52%) ⬆️
jwst/extract_2d/grisms.py 92.16% <0.00%> (+0.92%) ⬆️
jwst/resample/gwcs_drizzle.py 80.00% <0.00%> (+1.05%) ⬆️
jwst/ramp_fitting/ramp_fit_step.py 97.75% <0.00%> (+1.12%) ⬆️
jwst/resample/resample_step.py 89.94% <0.00%> (+1.18%) ⬆️
jwst/tweakreg/astrometric_utils.py 88.88% <0.00%> (+1.58%) ⬆️
jwst/assign_wcs/assign_wcs.py 80.70% <0.00%> (+1.75%) ⬆️
jwst/saturation/saturation.py 93.00% <0.00%> (+2.00%) ⬆️
... and 151 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

nden
nden approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator
@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hbushouse
Copy link
Collaborator

regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/520/testReport/

@nden nden merged commit 503e7a6 into spacetelescope:master Dec 23, 2022
@mcara mcara deleted the merge-fits-wcsinfo branch April 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

@hbushouse hbushouse hbushouse approved these changes

Assignees

@mcara mcara

Labels
assign_wcs
Projects
None yet
Milestone
Build 9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mcara @hbushouse @nden
0