8000 JP-2928: Update FGS image2 test with flight data by dmggh · Pull Request #7433 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2928: Update FGS image2 test with flight data #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 18, 2023
Merged

JP-2928: Update FGS image2 test with flight data #7433

merged 5 commits into from
Jan 18, 2023

Conversation

dmggh
Copy link
Contributor
@dmggh dmggh commented Jan 13, 2023 •
edited by hbushouse
Loading

Partially resolves JP-2928

This PR updates the FGS image2 reg test with flight data
Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@dmggh dmggh requested a review from hbushouse January 13, 2023 20:23
@dmggh dmggh self-assigned this Jan 13, 2023
@codecov
Copy link
codecov bot commented Jan 13, 2023 •
edited
Loading

Codecov Report

Base: 78.53% // Head: 78.53% // No change to project coverage 👍

Coverage data is based on head (386c5cd) compared to base (f25d3ee).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7433   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files         455      455           
  Lines       39084    39084           
=======================================
  Hits        30695    30695           
  Misses       8389     8389
Flag Coverage Δ *Carryforward flag
nightly 78.51% <ø> (ø) Carriedforward from cd8968a
unit 51.37% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hbushouse
hbushouse suggested changes Jan 17, 2023
View reviewed changes
@hbushouse hbushouse added this to the Build 9.2 milestone Jan 18, 2023
@hbushouse hbushouse merged commit cd17532 into master Jan 18, 2023
@hbushouse hbushouse deleted the hack_day_reg branch January 18, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees

@dmggh dmggh

Labels
FGS image2 pipeline regression_testing regression-test
Projects
None yet
Milestone
Build 9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dmggh @hbushouse
0