8000 Update sregion at the end of TweakRegStep by izkgao · Pull Request #8158 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update sregion at the end of TweakRegStep #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2024
Merged

Update sregion at the end of TweakRegStep #8158

merged 4 commits into from
Jan 12, 2024

Conversation

izkgao
Copy link
Contributor
@izkgao izkgao commented Dec 29, 2023 •
edited by hbushouse
Loading

This PR fixes an issue where sregion is not updated after corrections are applied to the WCS.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@izkgao izkgao marked this pull request as ready for review December 29, 2023 07:40
@izkgao izkgao requested a review from a team as a code owner December 29, 2023 07:40
@codecov Codecov
Copy link
codecov bot commented Dec 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c957490) 75.24% compared to head (961aa88) 75.25%.
Report is 1 commits behind head on master.

❗ Current head 961aa88 differs from pull request most recent head 94f37e1. Consider uploading reports for the commit 94f37e1 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8158   +/-   ##
=======================================
  Coverage   75.24%   75.25%           
=======================================
  Files         470      470           
  Lines       38430    38427    -3     
=======================================
- Hits        28918    28917    -1     
+ Misses       9512     9510    -2
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (+<0.01%) ⬆️ Carriedforward from b762c66

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nden nden requested a review from mcara January 2, 2024 14:12
@nden
Copy link
Collaborator
nden commented Jan 2, 2024

Regression tests run here:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1128/

@nden
Copy link
Collaborator
nden commented Jan 2, 2024 •
edited
Loading

I believe s_region is not used in the pipeline (though it may be in the future). It's added to the files so the footprint can be visualized in the archive. However, the output of tweakreg is not an archive product. Nevertheless, it may be good to update the keyword.

@izkgao
Copy link
Contributor Author
izkgao commented Jan 2, 2024

@nden Thank you for the information. The reason I want to update s_region is that I use s_region to find images that overlap with the image set to be used in the outlier detection step. In some extreme cases, not updating s_region can cause some of the overlapping images to be missed.

mcara
mcara approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member
@mcara mcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcara
Copy link
Member
mcara commented Jan 2, 2024

Thanks!

@hbushouse hbushouse added this to the Build 10.2 milestone Jan 8, 2024
hbushouse
hbushouse reviewed Jan 8, 2024
View reviewed changes
@izkgao izkgao force-pushed the tweakreg_update_sregion branch from bb68f7c to e34aad4 Compare January 10, 2024 05:20
@hbushouse hbushouse merged commit f23d4d9 into spacetelescope:master Jan 12, 2024
@jdavies-st
Copy link
Collaborator

the output of tweakreg is not an archive product.

The output eventually does get written out and archived as the _crf.fits files via outlier_detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcara mcara mcara approved these changes

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
tweakreg
Projects
None yet
Milestone
Build 10.2
Development

Successfully merging this pull request may close these issues.
5 participants
@izkgao @nden @mcara @jdavies-st @hbushouse
0