8000 Update min version of tweakwcs to 0.8.6 by hbushouse · Pull Request #8216 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update min version of tweakwcs to 0.8.6 #8216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update min version of tweakwcs to 0.8.6 #8216

merged 1 commit into from
Jan 24, 2024

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented Jan 24, 2024 •
edited
Loading

Related to JP-3468

This PR updates the minimum required version of tweakwcs, in order to take advantage of recent bug fixes, in particular the one described in JP-3468.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

8000
@hbushouse hbushouse requested a review from a team as a code owner January 24, 2024 14:15
@codecov Codecov
Copy link
codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (593cef1) 75.18% compared to head (d113291) 75.18%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8216   +/-   ##
=======================================
  Coverage   75.18%   75.18%           
=======================================
  Files         470      470           
  Lines       38542    38542           
=======================================
  Hits        28976    28976           
  Misses       9566     9566
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 593cef1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zacharyburnett
zacharyburnett approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator
@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass

@hbushouse hbushouse merged commit 2c6df23 into spacetelescope:master Jan 24, 2024
@hbushouse hbushouse deleted the update_tweakwcs branch January 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyburnett zacharyburnett zacharyburnett approved these changes

@braingram braingram Awaiting requested review from braingram

Assignees
No one assigned
Labels
installation no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbushouse @zacharyburnett
0