8000 require photutils 1.5+ by braingram · Pull Request #8211 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

require photutils 1.5+ #8211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

require photutils 1.5+ #8211

merged 2 commits into from
Jan 23, 2024

Conversation

braingram
Copy link
Collaborator
@braingram braingram commented Jan 23, 2024 •
edited by hbushouse
Loading

Following #8203 the oldest deps job is failing on main due to incompatibility with photutils 1.4.0.

This PR updates the minimum photutils version to 1.5.0.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@braingram
Copy link
Collaborator Author

Closing and reopening as a few jobs failed due to github errors.

@braingram braingram closed this Jan 23, 2024
@braingram braingram reopened this Jan 23, 2024
@codecov Codecov
Copy link
codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (c176ff3) 75.24% compared to head (582ec40) 75.18%.
Report is 1 commits behind head on master.

Files Patch % Lines
jwst/tweakreg/tweakreg_catalog.py 22.91% 37 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8211      +/-   ##
==========================================
- Coverage   75.24%   75.18%   -0.07%     
==========================================
  Files         470      470              
  Lines       38497    38542      +45     
==========================================
+ Hits        28968    28976       +8     
- Misses       9529     9566      +37
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (-0.01%) ⬇️ Carriedforward from fbcb989

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review January 23, 2024 17:41
@braingram braingram requested a review from a team as a code owner January 23, 2024 17:41
@braingram braingram requested review from emolter and removed request for a team January 23, 2024 17:41
@hbushouse hbushouse added this to the Build 10.2 milestone Jan 23, 2024
hbushouse
hbushouse approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator
@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The oldest deps CI job now passes.

@hbushouse hbushouse merged commit 593cef1 into spacetelescope:master Jan 23, 2024
@braingram braingram deleted the fix_min_deps branch January 23, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@emolter emolter Awaiting requested review from emolter

Assignees
No one assigned
Labels
installation
Projects
None yet
Milestone
Build 10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@braingram @hbushouse
0