8000 Fix NIRISS imaging regression test by hbushouse · Pull Request #8277 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix NIRISS imaging regression test #8277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix NIRISS imaging regression test #8277

merged 2 commits into from
Feb 16, 2024

Conversation

hbushouse
Copy link
Collaborator
@hbushouse hbushouse commented Feb 15, 2024 •
edited
Loading

This PR modifies the test_niriss_image regtest module to look for the input file in the appropriate folder in artifactory and expands the detector1 test to test the output of all intermediate steps. All necessary input/truth files are in place in artifactory. Ran the new version of the test module locally and all comparisons passed.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse hbushouse requested a review from a team as a code owner February 15, 2024 21:10
@codecov Codecov
Copy link
codecov bot commented Feb 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3f006a) 75.15% compared to head (a8967e2) 75.15%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8277   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files         470      470           
  Lines       38608    38608           
=======================================
  Hits        29017    29017           
  Misses       9591     9591
Flag Coverage Δ *Carryforward flag
nightly 77.38% <ø> (ø) Carriedforward from 38b3b01

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tapastro
Copy link
Contributor

Started regtest run: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1211/

Change looks good to me, pending test completion.

@hbushouse
Copy link
Collaborator Author

Regression test failures are unrelated. The 3 differences in resampled (i2d) products are due to merger of another PR earlier today.

emolter
emolter approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator
@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too

@hbushouse hbush 7C96 ouse merged commit 29b3e9d into spacetelescope:master Feb 16, 2024
@hbushouse hbushouse deleted the fix_nis_regtest branch February 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emolter emolter emolter approved these changes

@tapastro tapastro Awaiting requested review from tapastro

Assignees
No one assigned
Labels
NIRISS no-changelog-entry-needed regression_testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbushouse @tapastro @emolter
0