JP-3553: Update background step handling of multi-ints exposures #8326
8000Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regression test started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1252 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8326 +/- ##
==========================================
+ Coverage 75.15% 75.38% +0.22%
==========================================
Files 470 474 +4
Lines 38604 38904 +300
==========================================
+ Hits 29014 29326 +312
+ Misses 9590 9578 -12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Regtest run had 2 unrelated failures. So this PR is clean. |
emolter
approved these changes
Mar 4, 2024
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3553
Closes #8313
This PR updates the background subtraction step to make it more flexible in handling multi-integration background exposures (rateints files). Previously, the way the code was implemented, it was necessary to have NINTS be the same for the science exposure and all of the background exposures. This update allows the background exposures to have any value of NINTS and still be used correctly to form a mean background, which is subsequently subtracted from every integration of the science exposure. The problem with the previous code was that it was allocating internal arrays for working with the background images based on the shape of the science data, so if they different NINTS, the shape is wrong. This update simply allocates the internal background arrays based on the shape of each background image.
I've also incorporated the data that originally triggered this work into a new form of the existing regression test that runs the background step on multi-integration exposures. All of the necessary input and truth files have been uploaded to Artifactory and the updated test runs successfully on my local branch.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR