JP-3605: Change default value for abs_separation in the tweakreg step #8445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8445 +/- ##
=======================================
Coverage 56.38% 56.38%
=======================================
Files 387 387
Lines 38716 38716
=======================================
Hits 21830 21830
Misses 16886 16886 ☔ View full report in Codecov by Sentry. |
37fa745 to
c88f38d
Compare
nden
approved these changes
May 2, 2024
|
I was thinking maybe we should add a comment about the need for |
|
I agree we should add it to the general documentation and the parameter description. Another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3605
Closes #8436
This PR addresses possible crash in absolute alignment step:
#6987 exposed some of the previously hard-coded parameters for the absolute alignment step. At that time these parameters have not been adjusted in such a way as to avoid multiple detections within the tolerance circle (#6987 (comment)). This is the reason for these crashes. This PR increases
abs_separationto 1 arcsec.Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR