8000 JP-3312 Support Update from RHEL7 to RHEL9 by penaguerrero · Pull Request #8653 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-3312 Support Update from RHEL7 to RHEL9 #8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 24, 2024
Merged

JP-3312 Support Update from RHEL7 to RHEL9 #8653

merged 8 commits into from
Jul 24, 2024

Conversation

penaguerrero
Copy link
Contributor
@penaguerrero penaguerrero commented Jul 16, 2024 •
edited by melanieclarke
Loading

Resolves JP-3312

Closes #7753

This PR addresses the failing reg test test_miri_image3_catalog. The tolerance was not being propagated in the function call due to a missing parameter, when added the test passes.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@penaguerrero penaguerrero requested a review from a team as a code owner July 16, 2024 15:09
@stscijgbot-jp stscijgbot-jp mentioned this pull request Jul 16, 2024
Closed
@codecov Codecov
Copy link
codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (353666d) to head (2f4410f).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8653   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files         370      370           
  Lines       38630    38630           
=======================================
  Hits        23261    23261           
  Misses      15369    15369

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

melanieclarke
melanieclarke reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me!

@braingram
Copy link
Collaborator

As a proxy for RHEL9 here's a link to the github actions regression tests run with this PR:
https://github.com/spacetelescope/RegressionTests/actions/runs/9959697888
as noted in the ticket, the differences seen for RHEL9 look identical to those seen with ubuntu 20.04 (the OS used for github actions).

@melanieclarke melanieclarke added this to the Build 11.1 milestone Jul 23, 2024
@penaguerrero
Update CHANGES.rst
2f4410f 
removed comment since it does not affect behavior.
melanieclarke
melanieclarke approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the regression tests, it looks like there were some CRDS related issues in the psfalign tests, but the remainder all look like the expected diffs listed in JP-3312. The miri_image3_catalog test passed, so I think we can go ahead and merge this one.

@melanieclarke melanieclarke merged commit 50ec28d into spacetelescope:master Jul 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melanieclarke melanieclarke melanieclarke approved these changes

Assignees
No one assigned
Labels
MIRI no-changelog-entry-needed regression_testing
Projects
None yet
Milestone
Build 11.1
Development

Successfully merging this pull request may close these issues.

Support Update from RHEL7 to RHEL9
3 participants
@penaguerrero @braingram @melanieclarke
0