8000 Update regression tests to remove missing files from tests by tapastro · Pull Request #8730 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update regression tests to remove missing fi 8000 les from tests #8730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2024
Merged

Update regression tests to remove missing files from tests #8730

merged 3 commits into from
Sep 5, 2024

Conversation

tapastro
Copy link
Contributor

This PR addresses failing regression tests resulting from updated detector1 parameter reference files delivered by NIRCam and MIRI. The new reference files skip the refpix step for MIRI images and skip the persistence step for NIRCam data, resulting in test errors on missing {..}_refpix.fits and {..}_trapsfilled.fits files. This PR removes those suffixes/filenames from the test diffs.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro added this to the Build 11.1 milestone Aug 27, 2024
@tapastro tapastro requested a review from a team as a code owner August 27, 2024 14:14
@tapastro
Copy link
Contributor Author

After okifying the downstream results (i.e. ramp, rate, cal) to match the missing persistence entries, regtest run started here to verify the errors are no longer present: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1679/

@codecov Codecov
Copy link
codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (04217a2) to head (0a9dd12).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8730      +/-   ##
==========================================
+ Coverage   60.63%   60.77%   +0.13%     
==========================================
  Files         372      373       +1     
  Lines       38375    38596     +221     
==========================================
+ Hits        23270    23458     +188     
- Misses      15105    15138      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

melanieclarke
melanieclarke reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look right to me. There are many regression test failures - are those all expected, after your changes?

Should we also delete the files from the truth directories on artifactory, to tidy up?

@tapastro
Copy link
Contributor Author

To be safe, I've started a fresh run after okify'ing the new failures resulting from new CRDS context updates. Here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/

I can clean up the truth files once merged.

@melanieclarke
Copy link
Collaborator

I think the regtests look right now - build 1680? The LRS ones are expected with the rmap that needs fixing and the "full_run" one looks like it's probably related to the NIRCam READPATT. Is that right?

@tapastro tapastro merged commit da36be8 into spacetelescope:master Sep 5, 2024
29 checks passed
@tapastro tapastro deleted the update-regtests-skipped-steps branch September 5, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melanieclarke melanieclarke melanieclarke left review comments

Assignees
No one assigned
Labels
MIRI NIRCAM no-changelog-entry-needed regression_testing
Projects
None yet
Milestone
Build 11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tapastro @melanieclarke
0