8000 rename variable to silence sonarscan by braingram · Pull Request #8784 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

rename variable to silence sonarscan #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

rename variable to silence sonarscan #8784

merged 1 commit into from
Sep 13, 2024

Conversation

braingram
Copy link
Collaborator
@braingram braingram commented Sep 13, 2024 •
edited
Loading

Fixes: #8783

Github actions regression tests (which will run sonar scan): https://github.com/spacetelescope/RegressionTests/actions/runs/10851716705

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@braingram braingram marked this pull request as ready for review September 13, 2024 15:17
@braingram braingram requested a review from a team as a code owner September 13, 2024 15:17
@codecov Codecov
Copy link
codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.76%. Comparing base (418d9a8) to head (7a82b78).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8784   +/-   ##
=======================================
  Coverage   60.76%   60.76%           
=======================================
  Files         375      375           
  Lines       38382    38382           
=======================================
  Hits        23323    23323           
  Misses      15059    15059

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram merged commit 760e085 into spacetelescope:master Sep 13, 2024
29 of 30 checks passed
@braingram braingram deleted the sonar_scan branch September 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melanieclarke melanieclarke melanieclarke approved these changes

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SonarScan issue
3 participants
@braingram @melanieclarke @zacharyburnett
0