8000 Fix output collisions in clean_flicker_noise tests by melanieclarke · Pull Request #8805 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix output collisions in clean_flicker_noise tests #8805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix output collisions in clean_flicker_noise tests #8805

merged 1 commit into from
Sep 19, 2024

Conversation

melanieclarke
Copy link
Collaborator
@melanieclarke melanieclarke commented Sep 19, 2024 •
edited
Loading

Modifying the output file names so that products in the clean_flicker_noise run don't overwrite products in the standard run.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API?
    • add an entry to CHANGES.rst within the relevant release section (otherwise add the no-changelog-entry-needed label to this PR)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the Build 11.1 milestone Sep 19, 2024
@melanieclarke melanieclarke requested a review from a team as a code owner September 19, 2024 14:44
@melanieclarke
Copy link
Collaborator Author

I will upload the new expected truth files now and run regression tests. I can delete the stale truth files after this is merged.

@codecov Codecov
Copy link
codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.75%. Comparing base (2ff8573) to head (5783cfb).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8805   +/-   ##
=======================================
  Coverage   61.75%   61.75%           
=======================================
  Files         377      377           
  Lines       38750    38750           
=======================================
  Hits        23931    23931           
  Misses      14819    14819

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tapastro
tapastro approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor
@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@melanieclarke
Copy link
Collaborator Author

Regtests here:
https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1733/

@tapastro
Copy link
Contributor
8000 tapastro commented Sep 19, 2024

I think the regtest results all look expected, with the possible strangeness of the NIRISS test results with variance differences but no difference in step status. Curious how those could not be paired together...

@melanieclarke
Copy link
Collaborator Author

Regtests look as expected, so I will merge this and okify the results.

@melanieclarke
Copy link
Collaborator Author

I think the regtest results all look expected, with the possible strangeness of the NIRISS test results with variance differences but no difference in step status. Curious how those could not be paired together...

Sorry, just saw this. I made the new truth files it's comparing to with my local install, so the NIRISS cfn differences are probably due to differences between my working environment and Jenkins's cleaner one. I'll okify the Jenkins version.

@melanieclarke
Copy link
Collaborator Author

It does also look like there's an unrelated error in the badpix_selfcal test, from work in #8786. I'll send a separate PR for that.

@melanieclarke melanieclarke merged commit 4bfab7f into spacetelescope:master Sep 19, 2024
30 checks passed
@melanieclarke melanieclarke deleted the fix_cfn_tests branch September 19, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapastro tapastro tapastro approved these changes

Assignees
No one assigned
Labels
detector1 MIRI NIRCAM NIRISS NIRSPEC no-changelog-entry-needed regression_testing
Projects
None yet
Milestone
Build 11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@melanieclarke @tapastro
0