JP-3781: Use center=False for compute_s_region_imaging #8897
Conversation
|
Quick question - I believe cube_build already uses S_REGION to get spatial footprints for IFU data. Does this change impact that mode? |
|
Ok interesting. Cube_build does use the S_REGIONS. S_REGIONS is filled in in assign_wcs right ? Should it be updated there so downstream steps get the correct values ? |
This only impacts anything that uses |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8897 +/- ##
==========================================
+ Coverage 61.80% 61.85% +0.04%
==========================================
Files 377 377
Lines 38824 38873 +49
==========================================
+ Hits 23994 24043 +49
Misses 14830 14830 ☔ View full report in Codecov by Sentry. |
|
all regression test failures (aside from the 4 also on the main branch) pertain to S_REGION keywords, and all appear to be the magnitude we would expect. Marking this ready for review. |
Co-authored-by: Nadia Dencheva <nadia.astropy@gmail.com>
|
restarting regression tests here on Github Actions, now that the last of the differences have been ok-ified there and the okify script operates there |
|
I looked over the modules in assign_wcs.py util.py that deal with spectral data. The way they are designed I agree with you that I do not think this is an issue for spectral data. Not IFU nor NIRSpec slit data. |
…e#8897) Co-authored-by: Nadia Dencheva <nadia.astropy@gmail.com>
Resolves JP-3781
Closes #8896
This PR addresses a bug that makes the s_region for imaging data slightly incorrect. During testing of AL-837, it was discovered that the footprint encoded in model.meta.wcsinfo.s_region is not the same as what you get from
wcs.footprint(). By default in the pipeline, the s_region is currently calculated as the center of each corner pixel of the footprint usingstcal.alignment.util.compute_sregion_imaging(wcs, center=True), but it should calculate the true corners of the footprint using the same function but using the optioncenter=False. There is even a comment in that function stating thatcenter=Falseis usually what is desired.The change is a one-liner, but a fairly large number of regression test failures are expected.
Tasks
Build 11.3(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth filesnews fragment change types...
changes/<PR#>.general.rst: infrastructure or miscellaneous changechanges/<PR#>.docs.rstchanges/<PR#>.stpipe.rstchanges/<PR#>.datamodels.rstchanges/<PR#>.scripts.rstchanges/<PR#>.fits_generator.rstchanges/<PR#>.set_telescope_pointing.rstchanges/<PR#>.pipeline.rststage 1
changes/<PR#>.group_scale.rstchanges/<PR#>.dq_init.rstchanges/<PR#>.emicorr.rstchanges/<PR#>.saturation.rstchanges/<PR#>.ipc.rstchanges/<PR#>.firstframe.rstchanges/<PR#>.lastframe.rstchanges/<PR#>.reset.rstchanges/<PR#>.superbias.rstchanges/<PR#>.refpix.rstchanges/<PR#>.linearity.rstchanges/<PR#>.rscd.rstchanges/<PR#>.persistence.rstchanges/<PR#>.dark_current.rstchanges/<PR#>.charge_migration.rstchanges/<PR#>.jump.rstchanges/<PR#>.clean_flicker_noise.rstchanges/<PR#>.ramp_fitting.rstchanges/<PR#>.gain_scale.rststage 2
changes/<PR#>.assign_wcs.rstchanges/<PR#>.badpix_selfcal.rstchanges/<PR#>.msaflagopen.rstchanges/<PR#>.nsclean.rstchanges/<PR#>.imprint.rstchanges/<PR#>.background.rstchanges/<PR#>.extract_2d.rstchanges/<PR#>.master_background.rstchanges/<PR#>.wavecorr.rstchanges/<PR#>.srctype.rstchanges/<PR#>.straylight.rstchanges/<PR#>.wfss_contam.rstchanges/<PR#>.flatfield.rstchanges/<PR#>.fringe.rstchanges/<PR#>.pathloss.rstchanges/<PR#>.barshadow.rstchanges/<PR#>.photom.rstchanges/<PR#>.pixel_replace.rstchanges/<PR#>.resample_spec.rstchanges/<PR#>.residual_fringe.rstchanges/<PR#>.cube_build.rstchanges/<PR#>.extract_1d.rstchanges/<PR#>.resample.rststage 3
changes/<PR#>.assign_mtwcs.rstchanges/<PR#>.mrs_imatch.rstchanges/<PR#>.tweakreg.rstchanges/<PR#>.skymatch.rstchanges/<PR#>.exp_to_source.rstchanges/<PR#>.outlier_detection.rstchanges/<PR#>.tso_photometry.rstchanges/<PR#>.stack_refs.rstchanges/<PR#>.align_refs.rstchanges/<PR#>.klip.rstchanges/<PR#>.spectral_leak.rstchanges/<PR#>.combine_1d.rstchanges/<PR#>.ami.rstother
changes/<PR#>.wfs_combine.rstchanges/<PR#>.white_light.rstchanges/<PR#>.cube_skymatch.rstchanges/<PR#>.engdb_tools.rstchanges/<PR#>.guider_cds.rst