8000 JP-2928: Update MIRI MRS test data by melanieclarke · Pull Request #8936 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-2928: Update MIRI MRS test data #8936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2024
Merged

JP-2928: Update MIRI MRS test data #8936

merged 3 commits into from
Nov 6, 2024

Conversation

melanieclarke
Copy link
Collaborator
@melanieclarke melanieclarke commented Oct 31, 2024 •
edited
Loading

Partially addresses JP-2928

Update regression test data to in-flight examples for MIRI TSO and master background correction with a dedicated background observation.

For TSO, the data is from PID 1556 obs 1, detector = mirifushort.

For the background correction, the input data is a subset of the files in jw01031-c1004_20241028t205539_spec3_00001_asn.json, from PID 1031, obs 1 (science) and obs 6 (background). I included only the mirifulong inputs for the first sequence of both science and background observations. The input includes 4 cal files and 2 background spectra, equivalent to the (simulated) inputs for the existing test.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.fits_generator.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@melanieclarke melanieclarke added this to the Build 11.2 milestone Oct 31, 2024
@codecov Codecov
Copy link
codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (76d218b) to head (3cb6359).
Report is 526 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8936      +/-   ##
==========================================
- Coverage   64.52%   63.68%   -0.84%     
==========================================
  Files         375      375              
  Lines       38731    38691      -40     
==========================================
- Hits        24990    24640     -350     
- Misses      13741    14051     +310

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke
Copy link
Collaborator Author

Regression tests here:
https://github.com/spacetelescope/RegressionTests/actions/runs/11615060117

One unrelated failure, also failing on main.

@melanieclarke melanieclarke marked this pull request as ready for review October 31, 2024 16:49
@melanieclarke melanieclarke requested a review from a team as a code owner October 31, 2024 16:49
@stscijgbot-jp stscijgbot-jp mentioned this pull request Nov 4, 2024
Closed
@melanieclarke
Copy link
Collaborator Author

Thanks to feedback from @drlaw1558 and @jemorrison, I have removed the test for master background correction for nodded MIRI MRS data (test_miri_mrs_nod_masterbg.py). Master background corrections only proceed if there is a dedicated background observation, so test_miri_mrs_dedicated_mbkg should cover that case.

jemorrison
jemorrison approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator
@jemorrison jemorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New data and changes seem fine to me.

@jemorrison
Copy link
Collaborator

I wanted to review the regression tests results since this is a new system to me and I wanted to see how they looked.
when I click on the link in this pr to regression tests it just shows a nirspec failure - is that because there are no failures for these new tests because you updated the truth files

@melanieclarke
Copy link
Collaborator Author

I wanted to review the regression tests results since this is a new system to me and I wanted to see how they looked. when I click on the link in this pr to regression tests it just shows a nirspec failure - is that because there are no failures for these new tests because you updated the truth files

Yes, that's right. I generated the truth files with this branch on my local system and uploaded to artifactory before running the regression tests. They don't overlap with the old versions, so there are no conflicts with the truth files for the tests on main. The point in running them that way is mostly to make sure there aren't any architectural differences or installation problems in my local version versus the regression test system, as well as to make sure I haven't accidentally broken anything else.

@melanieclarke melanieclarke merged commit e898f2a into spacetelescope:main Nov 6, 2024
31 checks passed
@melanieclarke melanieclarke deleted the jp-2928-miri-mrs branch November 6, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemorrison jemorrison jemorrison approved these changes

Assignees
No one assigned
Labels
MIRI no-changelog-entry-needed regression_testing
Projects
None yet
Milestone
Build 11.2
Development

Successfully merging this pull request may close these issues.
2 participants
@melanieclarke @jemorrison
0