Document image group usage for sky matching #9080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73d3395 to
859c5bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9080 +/- ##
==========================================
+ Coverage 73.64% 73.66% +0.02%
==========================================
Files 368 368
Lines 36320 36391 +71
==========================================
+ Hits 26748 26808 +60
- Misses 9572 9583 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emolter
reviewed
Jan 16, 2025
kmacdonald-stsci
approved these changes
Jan 16, 2025
|
@tapastro - did you want to review this documentation change? |
7afe44e to
7f4f135
Compare
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
e4e1d5f to
adc0321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3843
Fixes #9063
This PR adds description of image groups in relation to sky matching and when grouping is desirable or not.
Tasks
- request a review from someone specific, to avoid making the maintainers review every PR
- add a build milestone, i.e.
- Does this PR change user-facing code / API? (if not, label with
- write news fragment(s) in
- update or add relevant tests
- update relevant docstrings and / or
- start a regression test and include a link to the running job (click here for instructions)
- Do truth files need to be updated ("okified")?
- after the reviewer has approved these changes, run
- if a JIRA ticket exists, make sure it is resolved properly
< 8000 /div>Build 11.3(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pageokify_regteststo update the truth files