8000 JP-3862: Clean up guider_cds step for code style and CRDS inconsistencies by tapastro · Pull Request #9141 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-3862: Clean up guider_cds step for code style and CRDS inconsistencies #9141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 26, 2025
Merged

JP-3862: Clean up guider_cds step for code style and CRDS inconsistencies #9141

merged 8 commits into from
Feb 26, 2025

Conversation

tapastro
Copy link
Contributor
@tapastro tapastro commented Feb 4, 2025 •
edited
Loading

Partially resolves JP-3862
Relates to CRDS-917
Addresses JP-3878
Addresses JP-3867

This PR addresses code style issues and some hard-wired reference file information present in the guider_cds step.

Unfortunately, we weren't able to completely remove some "workaround" behavior - for FGS_ID-STACK data, there is no gain or readnoise reference file matching the data array shape. In conversation with Pierre Chayer of the FGS team, it was confirmed that ID products are used to visually check where guide star and reference stars are located, but are not expected to be fully calibrated products; for stacked data, then, we apply the mean value of the fetched reference file array to the data (matching past behavior, though with a slighly different value).

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

othe 8000 r

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@tapastro tapastro added this to the Build 11.3 milestone Feb 4, 2025
@tapastro tapastro requested review from a team as code owners February 4, 2025 21:27
@codecov Codecov
Copy link
codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.83019% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.66%. Comparing base (e280308) to head (c718cba).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
jwst/guider_cds/guider_cds_step.py 10.00% 18 Missing ⚠️
jwst/guider_cds/guider_cds.py 78.12% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9141      +/-   ##
==========================================
- Coverage   73.67%   73.66%   -0.01%     
==========================================
  Files         368      368              
  Lines       36366    36365       -1     
==========================================
- Hits        26791    26790       -1     
  Misses       9575     9575

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

emolter
emolter reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator
@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, pending the fix for the failing unit tests

@emolter emolter self-requested a review February 5, 2025 15:39
melanieclarke
melanieclarke reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks sensible to me, pending the CRDS update for the appropriate reference files and a clean regtest run.

@tapastro tapastro force-pushed the jp-3862-guider-updates branch from 81e4ee6 to 322a2ad Compare February 25, 2025 20:51
@tapastro
Copy link
Contributor Author

New set of regtests here: https://github.com/spacetelescope/RegressionTests/actions/runs/13530716994

The un-xfailed regtest now shows expected failures - will okify post-merge.

melanieclarke
melanieclarke approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for getting this taken care of.

@melanieclarke melanieclarke merged commit b052727 into spacetelescope:main Feb 26, 2025
29 of 30 checks passed
This was referenced Feb 28, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melanieclarke melanieclarke melanieclarke approved these changes

@emolter emolter emolter approved these changes

Assignees
No one assigned
Labels
FGS guider_cds regression_testing source catalog technical-debt testing
Projects
None yet
Milestone
Build 11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@tapastro @melanieclarke @emolter
0