8000 JP-3856: Style Updates for Ramp Fitting by kmacdonald-stsci · Pull Request #9158 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

JP-3856: Style Updates for Ramp Fitting #9158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 11, 2025
Merged

JP-3856: Style Updates for Ramp Fitting #9158

merged 10 commits into from
Feb 11, 2025

Conversation

kmacdonald-stsci
Copy link
Contributor
@kmacdonald-stsci kmacdonald-stsci commented Feb 7, 2025 •
edited by melanieclarke
Loading

Partially resolves JP-5856
Partially resolves JP-5855

This PR addresses the style checkers using pre-commit.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.datamodels.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.set_telescope_pointing.rst
  • changes/<PR#>.pipeline.rst

stage 1

  • changes/<PR#>.group_scale.rst
  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.emicorr.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.ipc.rst
  • changes/<PR#>.firstframe.rst
  • changes/<PR#>.lastframe.rst
  • changes/<PR#>.reset.rst
  • changes/<PR#>.superbias.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.rscd.rst
  • changes/<PR#>.persistence.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.charge_migration.rst
  • changes/<PR#>.jump.rst
  • changes/<PR#>.clean_flicker_noise.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.gain_scale.rst

stage 2

  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.badpix_selfcal.rst
  • changes/<PR#>.msaflagopen.rst
  • changes/<PR#>.nsclean.rst
  • changes/<PR#>.imprint.rst
  • changes/<PR#>.background.rst
  • changes/<PR#>.extract_2d.rst
  • changes/<PR#>.master_background.rst
  • changes/<PR#>.wavecorr.rst
  • changes/<PR#>.srctype.rst
  • changes/<PR#>.straylight.rst
  • changes/<PR#>.wfss_contam.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.fringe.rst
  • changes/<PR#>.pathloss.rst
  • changes/<PR#>.barshadow.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.pixel_replace.rst
  • changes/<PR#>.resample_spec.rst
  • changes/<PR#>.residual_fringe.rst
  • changes/<PR#>.cube_build.rst
  • changes/<PR#>.extract_1d.rst
  • changes/<PR#>.resample.rst

stage 3

  • changes/<PR#>.assign_mtwcs.rst
  • changes/<PR#>.mrs_imatch.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.exp_to_source.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.tso_photometry.rst
  • changes/<PR#>.stack_refs.rst
  • changes/<PR#>.align_refs.rst
  • changes/<PR#>.klip.rst
  • changes/<PR#>.spectral_leak.rst
  • changes/<PR#>.source_catalog.rst
  • changes/<PR#>.combine_1d.rst
  • changes/<PR#>.ami.rst

other

  • changes/<PR#>.wfs_combine.rst
  • changes/<PR#>.white_light.rst
  • changes/<PR#>.cube_skymatch.rst
  • changes/<PR#>.engdb_tools.rst
  • changes/<PR#>.guider_cds.rst

@kmacdonald-stsci kmacdonald-stsci requested review from a team as code owners February 7, 2025 19:15
@codecov Codecov
Copy link
codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.85714% with 18 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (7440cfe) to head (dc65124).
Report is 847 commits behind head on main.

Files with missing lines Patch % Lines
jwst/ramp_fitting/ramp_fit_step.py 67.27% 18 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9158      +/-   ##
==========================================
+ Coverage   73.78%   73.80%   +0.01%     
==========================================
  Files         372      372              
  Lines       37290    37274      -16     
==========================================
- Hits        27516    27510       -6     
+ Misses       9774     9764      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

emolter
emolter reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator
@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, thanks Ken.

Would you run the regression test suite just in case? There are some small changes here, e.g. variable names, that aren't totally trivial and it would theoretically be possible to accidentally change a behavior (not that I think it's likely)

@kmacdonald-stsci
Copy link
Contributor Author

Code changes look good to me, thanks Ken.

Would you run the regression test suite just in case? There are some small changes here, e.g. variable names, that aren't totally trivial and it would theoretically be possible to accidentally change a behavior (not that I think it's likely)

I ran regression tests. The link is below.

https://github.com/spacetelescope/RegressionTests/actions/runs/13206518295

@emolter emolter self-requested a review February 10, 2025 14:22
@melanieclarke melanieclarke added this to the Build 11.3 milestone Feb 10, 2025
melanieclarke
melanieclarke reviewed Feb 10, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regtest results are as expected for the current state on main. I have a couple minor clean up requests and a procedural question.

@emolter
Copy link
Collaborator
emolter commented Feb 11, 2025

Readthedocs now seems to have found some indentation it does not understand...

melanieclarke
melanieclarke reviewed Feb 11, 2025
View reviewed changes
@melanieclarke
Copy link
Collaborator

Please fix the merge conflict, then this should be good to go.

melanieclarke
melanieclarke approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator
@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@melanieclarke melanieclarke merged commit 068aaf0 into spacetelescope:main Feb 11, 2025
29 of 30 checks passed
@kmacdonald-stsci kmacdonald-stsci deleted the jp_3856_ramp branch February 13, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emolter emolter emolter approved these changes

@melanieclarke melanieclarke melanieclarke approved these changes

@tapastro tapastro Awaiting requested review from tapastro

Assignees
No one assigned
Labels
no-changelog-entry-needed ramp_fitting testing
Projects
None yet
Milestone
Build 11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kmacdonald-stsci @emolter @melanieclarke
0