8000 Photom style by stscirij · Pull Request #9466 · spacetelescope/jwst · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Photom style #9466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Photom style #9466

wants to merge 3 commits into from
+1,191 −1,052

Conversation

stscirij
Copy link
Contributor

Addresses JP-3861

This PR applies code style changes to the photom package

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@stscirij stscirij requested review from a team as code owners May 14, 2025 21:31
emolter
emolter reviewed May 15, 2025
View reviewed changes
Copy link
Collaborator
@emolter emolter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much Robert, lots of code lines here! I had just a few small comments

Please run the regtests, too

@codecov Codecov
Copy link
codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.18519% with 121 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (9c837cd) to head (4ec4173).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
jwst/photom/photom.py 64.70% 72 Missing ⚠️
jwst/photom/miri_mrs.py 2.27% 43 Missing ⚠️
jwst/photom/photom_step.py 70.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9466      +/-   ##
==========================================
+ Coverage   77.86%   77.90%   +0.03%     
==========================================
  Files         362      362              
  Lines       36335    36341       +6     
==========================================
+ Hits        28294    28311      +17     
+ Misses       8041     8030      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stscirij
Copy link
Contributor Author

Regression test here:
https://github.com/spacetelescope/RegressionTests/actions/runs/15054035425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emolter emolter emolter left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
MIRI no-changelog-entry-needed photom testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stscirij @emolter
0